fix(torii-graphql): nullable array is empty string

[Larkooo]

Summary by CodeRabbit

• Bug Fixes
  • Improved handling of empty JSON array inputs to prevent potential parsing errors
  • Enhanced robustness of list value processing in data mapping

[coderabbitai]

Walkthrough

Ohayo, sensei! The changes involve enhancing the build_value_mapping function in the Torii GraphQL module to handle empty JSON list values more gracefully. The modification introduces a specific check for empty JSON strings when processing Value::List types, ensuring that an empty list is correctly inserted into the value mapping instead of potentially causing parsing errors.

Changes

File	Change Summary
crates/torii/graphql/src/query/mod.rs	Added conditional handling for empty JSON list values in build_value_mapping function

Sequence Diagram

sequenceDiagram
    participant Function as build_value_mapping
    participant Input as JSON Input
    participant Mapping as Value Mapping

    alt Empty JSON List
        Input ->> Function: Provide empty JSON string
        Function -->> Mapping: Insert empty list
        Function ->> Function: Continue to next iteration
    else Non-Empty JSON List
        Input ->> Function: Provide non-empty JSON string
        Function ->> Function: Parse JSON as before
        Function -->> Mapping: Insert parsed list
    end

Loading

The sequence diagram illustrates the new control flow, showing how the function now handles both empty and non-empty JSON list inputs differently, ensuring robust processing of various input scenarios.

---

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 7036164 and d4f4ee7.

📒 Files selected for processing (1)

• crates/torii/graphql/src/query/mod.rs (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (3)

• GitHub Check: clippy
• GitHub Check: docs
• GitHub Check: ensure-wasm

🔇 Additional comments (1)

crates/torii/graphql/src/query/mod.rs (1)

175-179: Ohayo sensei! Clean and elegant handling of empty JSON strings! ٩(◕‿◕｡)۶

The added check gracefully handles nullable arrays represented as empty strings by returning an empty list, preventing unnecessary JSON parsing attempts. The implementation is safe and maintains the function's error handling strategy.

Finishing Touches

• 📝 Generate Docstrings

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 55.78%. Comparing base (7036164) to head (d4f4ee7).
Report is 2 commits behind head on main.

Files with missing lines	Patch %	Lines
crates/torii/graphql/src/query/mod.rs	0.00%	4 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2882      +/-   ##
==========================================
- Coverage   55.78%   55.78%   -0.01%     
==========================================
  Files         448      448              
  Lines       57735    57739       +4     
==========================================
  Hits        32209    32209              
- Misses      25526    25530       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.