-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate configkit #53
Conversation
3339f80
to
b667304
Compare
This is nearing completion and is being used successfully in a branch of testkit. I need to add further tests. In general, |
184932d
to
9a7ce13
Compare
I've requested a review, but I don't really expect you to go through this with a fine-toothed comb. Danil, I believe next steps will be for me to start migrating the static analysis code. |
|
||
// Fidelity describes the configuration's accuracy in comparison to the | ||
// actual configuration that would be used at runtime. | ||
Fidelity Fidelity |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the term Fidelity
for sure 👍
What change does this introduce?
This PR introduces the
config
package as a replacement fordogmatiq/configkit
.It's not a direct replacement, as the API has changed somewhat, but it is structurally very similar and quite easy to migrate.
Why make this change?
In general it's an effort to reduce the dependency complexity for engines and related packages.
As regards the changes to the API, they are designed to address several shortcomings with
configkit
:configkit
had not beed updated to match, leading to its inability to represent things like "routing options" and "handler registration options"Command
,Event
andTimeout
interfaces are distinct.Is there anything you are unsure about?
No
What issues does this relate to?
#2