Bump rubocop-rails from 2.27.0 to 2.28.0 in the rubocop group

[dependabot]

Bumps the rubocop group with 1 update: rubocop-rails.

Updates rubocop-rails from 2.27.0 to 2.28.0

Release notes

Sourced from rubocop-rails's releases.

RuboCop Rails 2.28.0

New features

• #1383: Introduce AllCops: MigratedSchemaVersion config. (@​koic)

Bug fixes

• #1390: Fix an incorrect autocorrect for Rails/SelectMap when select has no receiver and method chains are used. (@​masato-bkn)
• #1382: Fix false negatives for Rails/RedundantActiveRecordAllMethod when using all method in block. (@​masato-bkn)
• #1397: Fix Rails/FilePath cop error on join method with implicit receiver. (@​viralpraxis)
• #1398: Fix Rails/FilePath cop error in case of extra operations in Rails.root interpolation. (@​viralpraxis)
• #1392: Fix Rails/FilePath cop error with rescued Rails.root. (@​viralpraxis)

Changes

• #1388: Modify Rails/Pluck to ignore map/collect when used inside blocks to prevent potential N+1 queries. (@​masato-bkn)

Changelog

Sourced from rubocop-rails's changelog.

2.28.0 (2024-12-25)

New features

• #1383: Introduce AllCops: MigratedSchemaVersion config. ([@​koic][])

Bug fixes

• #1390: Fix an incorrect autocorrect for Rails/SelectMap when select has no receiver and method chains are used. ([@​masato-bkn][])
• #1382: Fix false negatives for Rails/RedundantActiveRecordAllMethod when using all method in block. ([@​masato-bkn][])
• #1397: Fix Rails/FilePath cop error on join method with implicit receiver. ([@​viralpraxis][])
• #1398: Fix Rails/FilePath cop error in case of extra operations in Rails.root interpolation. ([@​viralpraxis][])
• #1392: Fix Rails/FilePath cop error with rescued Rails.root. ([@​viralpraxis][])

Changes

• #1388: Modify Rails/Pluck to ignore map/collect when used inside blocks to prevent potential N+1 queries. ([@​masato-bkn][])

Commits

• fcc4cf6 Cut 2.28.0
• bac0f3e Update Changelog
• 2c357f0 Merge pull request #1383 from koic/intro_migrated_schema_version
• 86b7a55 Introduce AllCops: MigratedSchemaVersion config
• 2671fb4 Merge pull request #1398 from viralpraxis/fix-rails-file-path-cop-error-on-jo...
• 815d119 Fix Rails/FilePath cop error on join method with implicit receiver
• fecead8 Merge pull request #1399 from viralpraxis/fix-rails-file-path-cop-error-on-ex...
• e4aee6b Fix Rails/FilePath cop error in case of extra operations in Rails.root in...
• c6f869b Merge pull request #1392 from viralpraxis/fix-rails-file-path-cop-error-with-...
• bb03d6b Fix Rails/FilePath cop error with rescued Rails.root
• Additional commits viewable in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

---

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

• @dependabot rebase will rebase this PR
• @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
• @dependabot merge will merge this PR after your CI passes on it
• @dependabot squash and merge will squash and merge this PR after your CI passes on it
• @dependabot cancel merge will cancel a previously requested merge and block automerging
• @dependabot reopen will reopen this PR if it is closed
• @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
• @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
• @dependabot ignore <dependency name> major version will close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself)
• @dependabot ignore <dependency name> minor version will close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself)
• @dependabot ignore <dependency name> will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself)
• @dependabot unignore <dependency name> will remove all of the ignore conditions of the specified dependency
• @dependabot unignore <dependency name> <ignore condition> will remove the ignore condition of the specified dependency and ignore conditions

[bmesuere]

This seems to modify the behaviour of the code (the tests fail)

[jorg-vr]

I've decided to ignore the newly complaining rubocop rule that limits chaining of safe navigation

The idea behind the rule that is less clear from the code which part of the chain can return nil.
But in places where long chains are actually used, multiple points in the chain can return nil and the code would become a lot more complex with multiple extra if checks if we want to correctly apply the rule.

IMO this isn't an improvement:

  def course_admin?
    return false unless user
    return false unless record
    return false unless record.evaluation
    return false unless record.evaluation.series

    user.course_admin?(record.evaluation.series.course)
  end

compared to:

  def course_admin?
    user&.course_admin?(record&.evaluation&.series&.course)
  end