Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't show zeus messages on submissions when in demo mode #5320

Merged
merged 5 commits into from
Jan 29, 2024
Merged

Don't show zeus messages on submissions when in demo mode #5320

merged 5 commits into from
Jan 29, 2024

Conversation

jorg-vr
Copy link
Contributor

@jorg-vr jorg-vr commented Jan 29, 2024 •
edited
Loading

This pull request removes zeus messages on submission when in demo mode.

Before
image

After
image

@jorg-vr jorg-vr added the enhancement A change that isn't substantial enough to be called a feature label Jan 29, 2024
@jorg-vr jorg-vr self-assigned this Jan 29, 2024
@jorg-vr jorg-vr requested a review from a team as a code owner January 29, 2024 09:34
@jorg-vr jorg-vr requested review from bmesuere and niknetniko and removed request for a team January 29, 2024 09:34
niknetniko
niknetniko approved these changes Jan 29, 2024
View reviewed changes
Copy link
Member

@niknetniko niknetniko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another more generic and impactful way to fix this: Remove all zeus rights when in demo mode by overwriting user.zeus?. But this might be to risky if there is no actual need for this feature.

I have no opinion on this.

@jorg-vr jorg-vr requested review from niknetniko January 29, 2024 10:45
@jorg-vr jorg-vr merged commit 1375001 into main Jan 29, 2024
13 checks passed
@jorg-vr jorg-vr deleted the enhance/demo-mode branch January 29, 2024 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bmesuere bmesuere bmesuere approved these changes

@niknetniko niknetniko Awaiting requested review from niknetniko

Assignees

@jorg-vr jorg-vr

Labels
enhancement A change that isn't substantial enough to be called a feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jorg-vr @bmesuere @niknetniko