Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new donation method and improve support visibility #5287

Merged
merged 12 commits into from
Jan 16, 2024
Merged

Conversation

jorg-vr
Copy link
Contributor

@jorg-vr jorg-vr commented Jan 12, 2024

This pull request updates the support_us page. I have added a button to the new online donation https://actieplatform.ugent.be/nl-NL/p/dodona/step-1
I also updated the text a bit to the current reality.

I Also added a support us button in our navigation as suggested by the Universiteitsfonds.
image

The link in the footer is still present when signed in, but the one in the header is removed
image

Misc:

  • I added a hover opacity to navbar links, as they didn't have any hover indication
  • I fixed the footer on smaller screens by hiding some links
    image
    image

@jorg-vr jorg-vr added the enhancement A change that isn't substantial enough to be called a feature label Jan 12, 2024
@jorg-vr jorg-vr self-assigned this Jan 12, 2024
@jorg-vr jorg-vr requested a review from a team as a code owner January 12, 2024 10:09
@jorg-vr jorg-vr requested review from bmesuere and niknetniko and removed request for a team January 12, 2024 10:09
@jorg-vr jorg-vr requested a review from chvp January 15, 2024 14:30
@chvp chvp added the deploy mestra Request a deployment on mestra label Jan 16, 2024
@github-actions github-actions bot removed the deploy mestra Request a deployment on mestra label Jan 16, 2024
Copy link
Member

@bmesuere bmesuere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • The top right navbar links could use a bit more horizontal margin/padding. The addition of the support us link caused the sign in button and language selector to be closer together (easiest to see if you compare a tab with mestra and dodona). In addition, I would add additional right margin to the nav bar button to make it stand out a bit.
  • On small screens, the top right navigation becomes a dropdown menu. There, the vertical spacing seems off a bit.
  • On the support us page itself, could we also add a button that links to the external platform to the top part of the page? Similar to where the "Sign in" button is on the signed out home page.
  • Do we have any control over the external website? The default amounts are quite high.
  • I would tweak the text in the "how can you support us" section a bit to make it clearer that the "make a donation" button is the easiest way to make a donation.

@jorg-vr jorg-vr marked this pull request as draft January 16, 2024 13:43
@jorg-vr
Copy link
Contributor Author

jorg-vr commented Jan 16, 2024

Do we have any control over the external website? The default amounts are quite high.

We could email them, maybe with an update once this is rolled out.
We don't have control ourselves

@jorg-vr jorg-vr marked this pull request as ready for review January 16, 2024 15:08
@jorg-vr jorg-vr requested a review from bmesuere January 16, 2024 15:09
@bmesuere bmesuere added the deploy mestra Request a deployment on mestra label Jan 16, 2024
@github-actions github-actions bot removed the deploy mestra Request a deployment on mestra label Jan 16, 2024
@jorg-vr jorg-vr merged commit f9f8fd9 into main Jan 16, 2024
15 checks passed
@jorg-vr jorg-vr deleted the enhance/support branch January 16, 2024 16:34
@bmesuere bmesuere changed the title Add new support method and improve support visibility Add new donation method and improve support visibility Jan 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement A change that isn't substantial enough to be called a feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants