-
-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new donation method and improve support visibility #5287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorg-vr
added
the
enhancement
A change that isn't substantial enough to be called a feature
label
Jan 12, 2024
jorg-vr
requested review from
bmesuere and
niknetniko
and removed request for
a team
January 12, 2024 10:09
chvp
reviewed
Jan 12, 2024
niknetniko
approved these changes
Jan 12, 2024
Co-authored-by: Charlotte Van Petegem <[email protected]>
chvp
approved these changes
Jan 16, 2024
bmesuere
requested changes
Jan 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- The top right navbar links could use a bit more horizontal margin/padding. The addition of the support us link caused the sign in button and language selector to be closer together (easiest to see if you compare a tab with mestra and dodona). In addition, I would add additional right margin to the nav bar button to make it stand out a bit.
- On small screens, the top right navigation becomes a dropdown menu. There, the vertical spacing seems off a bit.
- On the support us page itself, could we also add a button that links to the external platform to the top part of the page? Similar to where the "Sign in" button is on the signed out home page.
- Do we have any control over the external website? The default amounts are quite high.
- I would tweak the text in the "how can you support us" section a bit to make it clearer that the "make a donation" button is the easiest way to make a donation.
We could email them, maybe with an update once this is rolled out. |
bmesuere
approved these changes
Jan 16, 2024
bmesuere
changed the title
Add new support method and improve support visibility
Add new donation method and improve support visibility
Jan 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates the support_us page. I have added a button to the new online donation https://actieplatform.ugent.be/nl-NL/p/dodona/step-1
I also updated the text a bit to the current reality.
I Also added a support us button in our navigation as suggested by the Universiteitsfonds.
The link in the footer is still present when signed in, but the one in the header is removed
Misc: