Translate exercise names in search results #5274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorg-vr
requested review from
bmesuere and
chvp
and removed request for
a team
chvp
approved these changes
Jan 5, 2024
bmesuere
reviewed
Jan 5, 2024
| @@ -34,6 +34,10 @@ class SavedAnnotationState extends State { | |||
| @stateProperty private paginationByURL = new StateMap<string, Pagination>(); | |||
| @stateProperty private byId = new StateMap<number, SavedAnnotation>(); | |||
|
|
|||
| private get url(): string { | |||
| return `/${I18n.locale}${URL}`; | |||
There was a problem hiding this comment.
Can't we use I18n in a cleaner way? This is a hidden dependency which relies on a global variable being set without any fallback.
There was a problem hiding this comment.
The way I18n is handled is indeed legacy.
If we change how it is used, we should probably do a refactor of all usages.
Do you want me to update all in this pr or make a new pr?
There was a problem hiding this comment.
Since is has nothing to do with the rest of this fix, I think it's best done in a separate PR.
Feel free to check if there is similar technical debt we could fix.
bmesuere
approved these changes
Jan 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes exercise names appearing in the wrong language when searching through saved annotations.
Closes #5254