Recalculate selected code upon copy in submission #5157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorg-vr
requested review from
bmesuere and
niknetniko
and removed request for
a team
niknetniko
approved these changes
Nov 15, 2023
bmesuere
approved these changes
Nov 15, 2023
jorg-vr
changed the title
bmesuere
approved these changes
Nov 16, 2023
niknetniko
approved these changes
Nov 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request recalculates the selection when a copy event is triggered. This makes the code copy independent of the selectedRange tracked for the annotation form.
I had to improve the offset calculation a bit, because it did not work correctly if the focusnode itself was a PRE element (instead of a textnode child of a pre element). Now it should be more general and support both cases.
I also disabled range modification when triggered by the copy call. In the other use case the selection is being modified directly after creation which feels intuitive. But when it happens on copy it feels strange, and there is no good reason to do it. So I turned it off in that case.
Closes #5155