Skip to content

Commit

Permalink
Avoid duplicate series icon when favouriting a course
Browse files Browse the repository at this point in the history
  • Loading branch information
jorg-vr committed Feb 12, 2024
1 parent 481f7dd commit 3071036
Showing 1 changed file with 6 additions and 0 deletions.
6 changes: 6 additions & 0 deletions app/assets/javascripts/favorite_course_buttons.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
import { Toast } from "./toast";
import { fetch, getParentByClassName } from "utilities";
import { i18n } from "i18n/i18n";
import { SeriesIcon } from "components/series_icon";

function initFavoriteButtons(doc: Document | HTMLElement = document): void {
function init(): void {
Expand Down Expand Up @@ -44,6 +45,11 @@ function initFavoriteButtons(doc: Document | HTMLElement = document): void {
cloneFavButton.setAttribute("title", i18n.t("js.unfavorite-course-do"));
new bootstrap.Tooltip(cloneFavButton); // is enabled by default
cloneFavButton.addEventListener("click", toggleFavorite);
// hack to fix double rendering of content of lit element 'd-series-icon'
clone.querySelectorAll("d-series-icon").forEach((el: SeriesIcon) => {
el.replaceChildren();
el.requestUpdate();

Check warning on line 51 in app/assets/javascripts/favorite_course_buttons.ts

View check run for this annotation

Codecov / codecov/patch

app/assets/javascripts/favorite_course_buttons.ts#L49-L51

Added lines #L49 - L51 were not covered by tests
});
} else {
new Toast(i18n.t("js.favorite-course-failed"));
}
Expand Down

0 comments on commit 3071036

Please sign in to comment.