Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENGDOCS-1771 #18613

Merged
merged 15 commits into from
Nov 9, 2023
Merged

ENGDOCS-1771 #18613

merged 15 commits into from
Nov 9, 2023

Conversation

aevesdocker
Copy link
Contributor

Proposed changes

Related issues (optional)

Copy link

netlify bot commented Nov 8, 2023

Deploy Preview for docsdocker ready!

Name Link
🔨 Latest commit 7e0ed51
🔍 Latest deploy log https://app.netlify.com/sites/docsdocker/deploys/654ca3aa26dd5000083b031d
😎 Deploy Preview https://deploy-preview-18613--docsdocker.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@aevesdocker aevesdocker marked this pull request as ready for review November 8, 2023 13:45
@aevesdocker
Copy link
Contributor Author

Good lord...so many links to deal with 😱
PR is ready for review when you are @stephaurelio @craig-osterhout

Copy link
Contributor

@stephaurelio stephaurelio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing ✨ only one small nit and a stray link that I found. Otherwise link testing went well and also tested out the old URLs.

content/docker-hub/general-faqs.md Outdated Show resolved Hide resolved
content/security/_index.md Outdated Show resolved Hide resolved
@aevesdocker aevesdocker merged commit 0f2fe1d into docker:main Nov 9, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants