-
Notifications
You must be signed in to change notification settings - Fork 7.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
scout attest ootb policy #18606
scout attest ootb policy #18606
Conversation
dvdksn
commented
Nov 6, 2023
- scout: add attestation ootb policy
- build: clarify default image store limitation
✅ Deploy Preview for docsdocker ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
f09774d
to
c44a79e
Compare
c44a79e
to
7114da9
Compare
Signed-off-by: David Karlsson <[email protected]>
7114da9
to
6391863
Compare
content/scout/policy/_index.md
Outdated
[provenance](../../build/attestations/slsa-provenance.md) attestations. | ||
|
||
This policy is unfulfilled if an artifact is lacking either an SBOM | ||
attestation, or a provenance attestation with information about the Git |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
condition is backwards here, should be
..., or a provenance attestation without information about the Git repository and base images is being used`
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe the wording is not perfect here but saying that "policy is unfulfilled if an artifact is lacking [...] a provenance attestation without information about the Git repository and base images" becomes a double negative.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It reads to me currently as
policy is unfulfilled if ... a provenance attestation with information about the Git repository and base images is being used.
which is the opposite of what we want.
Maybe this?
This policy is unfulfilled if an artifact is lacking either an SBOM attestation
or a provenance attestation, or if the provenance is lacking information
about the Git repository and base images used.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
your suggestion reads better, let me update it
6391863
to
781ade2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Noted a minor suggestion. Looks good otherwise
Signed-off-by: David Karlsson <[email protected]>
781ade2
to
241040e
Compare