Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update go language-specific guide #18562

Merged
merged 4 commits into from
Nov 2, 2023
Merged

update go language-specific guide #18562

merged 4 commits into from
Nov 2, 2023

Conversation

craig-osterhout
Copy link
Contributor

@craig-osterhout craig-osterhout commented Oct 31, 2023 •
edited
Loading

Proposed changes

Update Go language-specific guide.

  • Remove cloud integrations from Deployment and replace with steps to run app locally in Kubernetes.
  • Update CI/CD based on sample app.
  • Update sample app repo as access was not set correctly on the other. Updated sample app to be compatible with postgres docker/docker-gs-ping-dev@d6cd25c

https://deploy-preview-18562--docsdocker.netlify.app/language/golang/develop/
https://deploy-preview-18562--docsdocker.netlify.app/language/golang/configure-ci-cd/
https://deploy-preview-18562--docsdocker.netlify.app/language/golang/deploy/

Related issues (optional)

ENGDOCS-1493

@craig-osterhout
update deploy and ci-cd in go guide
45dfa36 
Signed-off-by: Craig Osterhout <[email protected]>
@craig-osterhout
update repo
9db1760 
Signed-off-by: Craig Osterhout <[email protected]>
@craig-osterhout
update toc
0603756 
Signed-off-by: Craig Osterhout <[email protected]>
@craig-osterhout craig-osterhout requested a review from a team October 31, 2023 21:32
@netlify Netlify
Copy link

netlify bot commented Oct 31, 2023 •
edited
Loading

✅ Deploy Preview for docsdocker ready!

Name Link
🔨 Latest commit 6e4621b
🔍 Latest deploy log https://app.netlify.com/sites/docsdocker/deploys/654177015712730008b06fc0
😎 Deploy Preview https://deploy-preview-18562--docsdocker.netlify.app/language/golang/deploy
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@craig-osterhout
polish deploy
6e4621b 
Signed-off-by: Craig Osterhout <[email protected]>
@craig-osterhout craig-osterhout marked this pull request as ready for review October 31, 2023 21:52
@stephaurelio stephaurelio requested review from stephaurelio and removed request for a team November 2, 2023 20:31
stephaurelio
stephaurelio approved these changes Nov 2, 2023
View reviewed changes
Copy link
Contributor

@stephaurelio stephaurelio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@craig-osterhout craig-osterhout merged commit c8f0c28 into docker:main Nov 2, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stephaurelio stephaurelio stephaurelio approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@craig-osterhout @stephaurelio