Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update build-images.md #18523

Closed
wants to merge 1 commit into from
Closed

Update build-images.md #18523

wants to merge 1 commit into from

Conversation

Yachika9925
Copy link
Contributor

fixes #18520

Proposed changes

Related issues (optional)

@netlify
Copy link

netlify bot commented Oct 26, 2023

Deploy Preview for docsdocker ready!

Name Link
🔨 Latest commit 8289091
🔍 Latest deploy log https://app.netlify.com/sites/docsdocker/deploys/653a492a2dc9d70008503954
😎 Deploy Preview https://deploy-preview-18523--docsdocker.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

@rafvasq rafvasq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Yachika9925, but there are other parts of the tutorial that need to be changed too such as the Dockerfile examples.

Copy link
Collaborator

@dvdksn dvdksn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the pr @Yachika9925, can you please change the other references to go 1.19 as well? thank you

@craig-osterhout craig-osterhout added the area/get-started Relates to get started and onboarding docs label Dec 11, 2023
@craig-osterhout
Copy link
Contributor

Thanks for updating this. The requirement to install Go has been removed.
The sample apps and snippets of the Dockerfile still need to be updated in the docs. If you'd like to tackle that, it might be better to open a PR to the sample app repos (linked below) as a first step. Closing this PR.

https://github.com/docker/docker-gs-ping
https://github.com/docker/docker-gs-ping-dev

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/get-started Relates to get started and onboarding docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update "Build your Go image" tutorial to use supported Go version
4 participants