-
Notifications
You must be signed in to change notification settings - Fork 7.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Remove firewalld zone instructions #17389
docs: Remove firewalld zone instructions #17389
Conversation
✅ Deploy Preview for docsdocker ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
@akerouanton can you PTAL? TIA! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks for the pull request. We'd like to make our product docs better, but haven’t been able to review all the suggestions. If the updates are still relevant, review our contribution guidelines and rebase your pull request against the latest version of the docs, then mark it as fresh with a Prevent pull requests from auto-closing with a /lifecycle stale |
These were related to migrating to the `docker` zone support in new moby releases since integration landed in 2020H2.
0954c07
to
a452d69
Compare
Since the PR was raised, the original file was deleted and the content for firewalls relocated. Nothing has changed since the LGTM beyond adjusting to the new filename. |
@dvdksn @neersighted would it be possible to get this merged before it becomes stale again? 😅 Thanks :) |
I think we were waiting for @akerouanton to find time/bandwidth; so friendly poke 😀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Proposed changes
Remove instructions for migrating to the
docker
zone, which landed in moby releases since 2020H2.A recent PR commit modified these docs for v23 to remove the
20.10.0
qualifier (which lost that context).Additional Context
This makes the current information confusing, and implies a user should run similar commands to get integration with firewalld.
docker0
from thedocker
zone, will reassign it back, or if assigned to another zone with--permanent
cause a failure fordockerd
starting due to a conflicting zone already assigneddocker0
.Thus given the recent change, these instructions should be dropped, or additional context provided (note: third-party guides created in 2023 can be found advising to assign
docker0
totrusted
zone).