Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "set GIT_AUTH_TOKEN secret if Git context used" #285

Merged
merged 2 commits into from
Jan 14, 2025

Conversation

crazy-max
Copy link
Member

@crazy-max crazy-max commented Jan 14, 2025

Looks like secrets override doesn't append to ones from the bake definition but overwrites: docker/buildx#2912

Let's revert this change and fix this issue as follow-up.

@crazy-max crazy-max requested a review from tonistiigi January 14, 2025 13:50
@crazy-max crazy-max marked this pull request as ready for review January 14, 2025 13:51
@crazy-max crazy-max merged commit 5dd4f8e into docker:master Jan 14, 2025
40 checks passed
@crazy-max crazy-max deleted the revert-git-auth-token branch January 14, 2025 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant