Skip to content

Commit

Permalink
Update comment
Browse files Browse the repository at this point in the history
Co-authored-by: Keith Turner <[email protected]>
  • Loading branch information
dlmarion and keith-turner authored Dec 6, 2023
1 parent 21a3192 commit e6452c0
Showing 1 changed file with 5 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -959,6 +959,11 @@ private TabletMetadata commitCompaction(TCompactionStats stats, ExternalCompacti
var result = tabletsMutator.process().get(extent);
if (result.getStatus() == Ample.ConditionalResult.Status.ACCEPTED) {
// compaction was committed, mark the compaction input files for deletion
// ELASTICITIY_TODO in the case of process death the GC candidates would never be added like #3811. If
// compaction commit were moved to FATE per #3559 then this would not be an issue. If compaction
// commit is never moved to FATE, then this addition could moved to the compaction refresh
// process. The compaction refresh procss will go away if compaction commit is moved to FATE, so
// should only do this if not moving to FATE.
ctx.getAmple().putGcCandidates(extent.tableId(), ecm.getJobFiles());
break;
} else {
Expand Down

0 comments on commit e6452c0

Please sign in to comment.