Skip to content

Commit

Permalink
Fix some failing ITs, increase timeouts and reclassifiy metrics (apac…
Browse files Browse the repository at this point in the history
  • Loading branch information
dlmarion authored Nov 1, 2023
1 parent b0a2a42 commit 7fe3cfd
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 5 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ public class DeletedTablesDontFlushIT extends SharedMiniClusterBase {

@Override
protected Duration defaultTimeout() {
return Duration.ofMinutes(1);
return Duration.ofMinutes(2);
}

@BeforeAll
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -96,14 +96,13 @@ public void confirmMetricsPublished() throws Exception {

Set<String> unexpectedMetrics = Set.of(METRICS_SCAN_YIELDS, METRICS_UPDATE_ERRORS,
METRICS_SCAN_BUSY_TIMEOUT, METRICS_SCAN_PAUSED_FOR_MEM, METRICS_SCAN_RETURN_FOR_MEM,
METRICS_MINC_PAUSED, METRICS_MAJC_PAUSED, METRICS_MAJC_QUEUED, METRICS_MAJC_RUNNING,
METRICS_MANAGER_ROOT_TGW_ERRORS, METRICS_MANAGER_META_TGW_ERRORS,
METRICS_MANAGER_USER_TGW_ERRORS);
METRICS_MINC_PAUSED, METRICS_MAJC_PAUSED, METRICS_MAJC_QUEUED, METRICS_MAJC_RUNNING);
Set<String> flakyMetrics = Set.of(METRICS_GC_WAL_ERRORS, METRICS_FATE_TYPE_IN_PROGRESS,
METRICS_PROPSTORE_EVICTION_COUNT, METRICS_PROPSTORE_REFRESH_COUNT,
METRICS_PROPSTORE_REFRESH_LOAD_COUNT, METRICS_PROPSTORE_ZK_ERROR_COUNT,
METRICS_TSERVER_TABLETS_ONLINE_ONDEMAND, METRICS_TSERVER_TABLETS_ONDEMAND_UNLOADED_FOR_MEM,
METRICS_COMPACTOR_MAJC_STUCK);
METRICS_COMPACTOR_MAJC_STUCK, METRICS_MANAGER_ROOT_TGW_ERRORS,
METRICS_MANAGER_META_TGW_ERRORS, METRICS_MANAGER_USER_TGW_ERRORS);

Map<String,String> expectedMetricNames = this.getMetricFields();
flakyMetrics.forEach(expectedMetricNames::remove); // might not see these
Expand Down

0 comments on commit 7fe3cfd

Please sign in to comment.