forked from apache/accumulo
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Modified SimpleGarbageCollector to acquire the service lock in the same manner that other HA services acquire the service lock. Created a new class called ServiceLockSupport that is currently used to hold LockWatcher implementations for HA and non-HA servers. Closes apache#4839
- Loading branch information
Showing
9 changed files
with
192 additions
and
294 deletions.
There are no files selected for viewing
152 changes: 152 additions & 0 deletions
152
core/src/main/java/org/apache/accumulo/core/fate/zookeeper/ServiceLockSupport.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,152 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one | ||
| * or more contributor license agreements. See the NOTICE file | ||
| * distributed with this work for additional information | ||
| * regarding copyright ownership. The ASF licenses this file | ||
| * to you under the Apache License, Version 2.0 (the | ||
| * "License"); you may not use this file except in compliance | ||
| * with the License. You may obtain a copy of the License at | ||
| * | ||
| * https://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, | ||
| * software distributed under the License is distributed on an | ||
| * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| * KIND, either express or implied. See the License for the | ||
| * specific language governing permissions and limitations | ||
| * under the License. | ||
| */ | ||
| package org.apache.accumulo.core.fate.zookeeper; | ||
|
|
||
| import java.util.function.Consumer; | ||
| import java.util.function.Supplier; | ||
|
|
||
| import org.apache.accumulo.core.fate.zookeeper.ServiceLock.AccumuloLockWatcher; | ||
| import org.apache.accumulo.core.fate.zookeeper.ServiceLock.LockLossReason; | ||
| import org.apache.accumulo.core.fate.zookeeper.ServiceLock.LockWatcher; | ||
| import org.apache.accumulo.core.util.Halt; | ||
| import org.apache.zookeeper.KeeperException.NoAuthException; | ||
| import org.slf4j.Logger; | ||
| import org.slf4j.LoggerFactory; | ||
|
|
||
| public class ServiceLockSupport { | ||
|
|
||
| /** | ||
| * Lock Watcher used by Highly Available services. These are services where only instance is | ||
| * running at a time, but another backup service can be started that will be used if the active | ||
| * service instance fails and loses its lock in ZK. | ||
| */ | ||
| public static class HAServiceLockWatcher implements AccumuloLockWatcher { | ||
|
|
||
| private static final Logger LOG = LoggerFactory.getLogger(HAServiceLockWatcher.class); | ||
|
|
||
| private final String serviceName; | ||
| private volatile boolean acquiredLock = false; | ||
| private volatile boolean failedToAcquireLock = false; | ||
|
|
||
| public HAServiceLockWatcher(String serviceName) { | ||
| this.serviceName = serviceName; | ||
| } | ||
|
|
||
| @Override | ||
| public void lostLock(LockLossReason reason) { | ||
| Halt.halt(serviceName + " lock in zookeeper lost (reason = " + reason + "), exiting!", -1); | ||
| } | ||
|
|
||
| @Override | ||
| public void unableToMonitorLockNode(final Exception e) { | ||
| // ACCUMULO-3651 Changed level to error and added FATAL to message for slf4j compatibility | ||
| Halt.halt(-1, | ||
| () -> LOG.error("FATAL: No longer able to monitor {} lock node", serviceName, e)); | ||
|
|
||
| } | ||
|
|
||
| @Override | ||
| public synchronized void acquiredLock() { | ||
| LOG.debug("Acquired {} lock", serviceName); | ||
|
|
||
| if (acquiredLock || failedToAcquireLock) { | ||
| Halt.halt("Zoolock in unexpected state AL " + acquiredLock + " " + failedToAcquireLock, -1); | ||
| } | ||
|
|
||
| acquiredLock = true; | ||
| notifyAll(); | ||
| } | ||
|
|
||
| @Override | ||
| public synchronized void failedToAcquireLock(Exception e) { | ||
| LOG.warn("Failed to get {} lock", serviceName, e); | ||
|
|
||
| if (e instanceof NoAuthException) { | ||
| String msg = | ||
| "Failed to acquire " + serviceName + " lock due to incorrect ZooKeeper authentication."; | ||
| LOG.error("{} Ensure instance.secret is consistent across Accumulo configuration", msg, e); | ||
| Halt.halt(msg, -1); | ||
| } | ||
|
|
||
| if (acquiredLock) { | ||
| Halt.halt("Zoolock in unexpected state acquiredLock true with FAL " + failedToAcquireLock, | ||
| -1); | ||
| } | ||
|
|
||
| failedToAcquireLock = true; | ||
| notifyAll(); | ||
| } | ||
|
|
||
| public synchronized void waitForChange() { | ||
| while (!acquiredLock && !failedToAcquireLock) { | ||
| try { | ||
| LOG.info("{} lock held by someone else, waiting for a change in state", serviceName); | ||
| wait(); | ||
| } catch (InterruptedException e) { | ||
| // empty | ||
| } | ||
| } | ||
| } | ||
|
|
||
| public boolean isLockAcquired() { | ||
| return acquiredLock; | ||
| } | ||
|
|
||
| public boolean isFailedToAcquireLock() { | ||
| return failedToAcquireLock; | ||
| } | ||
|
|
||
| } | ||
|
|
||
| /** | ||
| * Lock Watcher used by non-HA services | ||
| */ | ||
| public static class ServiceLockWatcher implements LockWatcher { | ||
|
|
||
| private static final Logger LOG = LoggerFactory.getLogger(ServiceLockWatcher.class); | ||
|
|
||
| private final String serviceName; | ||
| private final Supplier<Boolean> shuttingDown; | ||
| private final Consumer<String> lostLockAction; | ||
|
|
||
| public ServiceLockWatcher(String serviceName, Supplier<Boolean> shuttingDown, | ||
| Consumer<String> lostLockAction) { | ||
| this.serviceName = serviceName; | ||
| this.shuttingDown = shuttingDown; | ||
| this.lostLockAction = lostLockAction; | ||
| } | ||
|
|
||
| @Override | ||
| public void lostLock(final LockLossReason reason) { | ||
| Halt.halt(1, () -> { | ||
| if (!shuttingDown.get()) { | ||
| LOG.error("{} lost lock (reason = {}), exiting.", serviceName, reason); | ||
| } | ||
| lostLockAction.accept(serviceName); | ||
| }); | ||
| } | ||
|
|
||
| @Override | ||
| public void unableToMonitorLockNode(final Exception e) { | ||
| Halt.halt(1, () -> LOG.error("Lost ability to monitor {} lock, exiting.", serviceName, e)); | ||
| } | ||
|
|
||
| } | ||
|
|
||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
94 changes: 0 additions & 94 deletions
94
...ion-coordinator/src/main/java/org/apache/accumulo/coordinator/CoordinatorLockWatcher.java
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.