partition: add repair capabilities to GPT #187
Conversation
|
@thebsdbox is great, isn't he? Did he do work elsewhere that you are moving in here? |
adamqqqplay
force-pushed
the
repair-gpt
branch
from
c938571 to
77a4994
Compare
partition/gpt/table.go
Outdated
| // potential protective MBR is at LBA0 | ||
| hasProtectiveMBR := readProtectiveMBR(b[:logicalBlockSize], uint32(header.secondaryHeader)) | ||
|
|
||
| table := Table{ |
There was a problem hiding this comment.
Rather than copying the fields, since readGptHeader() returns *Table, wouldn't it be easier to just add the data to it and return it? Something like:
table, err := readGptHeader(gpt)
// .. lots of other stuff
table.LogicalSectorSize = logicalBlockSize
table.PhysicalSectorSize = physicalBlockSize
table.ProtectiveMBR = hasProtectiveMBR
table.initialized = trueThere was a problem hiding this comment.
Thanks for your suggestion, I updated code.
partition/gpt/table.go
Outdated
| // GPT starts at LBA1 | ||
| gpt := b[logicalBlockSize:] | ||
| // readGptHeader reads the GPT header from the given byte slice | ||
| func readGptHeader(b []byte) (*Table, error) { |
There was a problem hiding this comment.
I suspect lint will complain that this should be readGPTHeader()
1. add Repair and Verify interfaces in type table 2. add test to test opening the GPT image Signed-off-by: thebsdbox <[email protected]> Signed-off-by: Qinqi Qu <[email protected]>
adamqqqplay
force-pushed
the
repair-gpt
branch
from
77a4994 to
610b365
Compare
|
@deitch Thanks for your review! I just discovered a new improvement point. Maybe we could merge this two function in the future: tableFromBytes and tableHeaderFromBytes. |
|
If it is easier, sure. These are private functions, so no worry about impact other than where they exist, and ability to read clearly. |
|
Apologies, I was always meant to circle back and finish this off :-( |
Based on #112, and addressing review comments. Thanks to the original author! @thebsdbox