Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up trajectory interface #377

Merged
merged 3 commits into from
Oct 18, 2023
Merged

Clean up trajectory interface #377

merged 3 commits into from
Oct 18, 2023

Conversation

jeremykubica
Copy link
Contributor

Small PR to move some of the trajectory position prediction functionality out of StackSearch and into Trajectory. Also remove the mostly unused get_trajectory_positions function (to simplify the interface) and add doc strings.

@wilsonbb wilsonbb self-requested a review October 18, 2023 20:20
wilsonbb
wilsonbb approved these changes Oct 18, 2023
View reviewed changes
Copy link
Collaborator

@wilsonbb wilsonbb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@jeremykubica jeremykubica merged commit 131eb7c into main Oct 18, 2023
1 check passed
@jeremykubica jeremykubica deleted the trajectory branch October 18, 2023 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wilsonbb wilsonbb wilsonbb approved these changes

@DinoBektesevic DinoBektesevic Awaiting requested review from DinoBektesevic

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jeremykubica @wilsonbb