Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: replace markdown-it-directive with @diplodoc/directive #52

Merged
merged 3 commits into from
Nov 15, 2024
Merged

feat: replace markdown-it-directive with @diplodoc/directive #52

merged 3 commits into from
Nov 15, 2024

Conversation

d3m1d0v
Copy link
Member

@d3m1d0v d3m1d0v commented Nov 12, 2024

No description provided.

@d3m1d0v d3m1d0v requested a review from makhnatkin November 12, 2024 19:21
@d3m1d0v d3m1d0v force-pushed the use-diplodoc-directive branch from 1b11189 to 170cec0 Compare November 12, 2024 20:16
@d3m1d0v d3m1d0v force-pushed the use-diplodoc-directive branch from 170cec0 to b6f59af Compare November 13, 2024 10:15
@d3m1d0v d3m1d0v marked this pull request as ready for review November 13, 2024 10:15
@makhnatkin
Copy link
Collaborator

Also let's update https://github.com/diplodoc-platform/html-extension/blob/master/README.md

makhnatkin
makhnatkin reviewed Nov 13, 2024
View reviewed changes
package.json Outdated Show resolved Hide resolved
@d3m1d0v d3m1d0v force-pushed the use-diplodoc-directive branch from 1341fc9 to 49504bb Compare November 13, 2024 13:29
brotheroftux
brotheroftux reviewed Nov 13, 2024
View reviewed changes
Copy link
Contributor

@brotheroftux brotheroftux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from the (slight) issue I mentioned, everything else looks good to me.

src/plugin/transform.ts Outdated Show resolved Hide resolved
@makhnatkin makhnatkin merged commit d853d00 into master Nov 15, 2024
2 checks passed
@d3m1d0v d3m1d0v deleted the use-diplodoc-directive branch November 15, 2024 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brotheroftux brotheroftux brotheroftux left review comments

@makhnatkin makhnatkin makhnatkin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@d3m1d0v @makhnatkin @brotheroftux