Skip to content

Commit

Permalink
Merge pull request #51 from UrsKahmann/fix/inline_comments
Browse files Browse the repository at this point in the history
Fix Inline Comments
  • Loading branch information
diogot authored Jul 5, 2020
2 parents f03890a + 43c3b50 commit 340e017
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 3 deletions.
3 changes: 2 additions & 1 deletion lib/xcode_summary/plugin.rb
Original file line number Diff line number Diff line change
Expand Up @@ -207,7 +207,8 @@ def errors(xcode_summary)

def parse_location(input)
file_path, line, _column = input[:file_path].split(':')
Location.new(input[:file_name], file_path, line.to_i)
file_name = relative_path(file_path)
Location.new(file_name, file_path, line.to_i)
end

def parse_test_location(failure)
Expand Down
4 changes: 2 additions & 2 deletions spec/xcode_summary_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -131,13 +131,13 @@ module Danger
expect(@xcode_summary).to have_received(:warn).with(
instance_of(String),
sticky: false,
file: 'Bla.m',
file: 'MyWeight/Bla.m',
line: 32
)
expect(@xcode_summary).to have_received(:warn).with(
instance_of(String),
sticky: false,
file: 'ISO8601DateFormatter.m',
file: 'MyWeight/Pods/ISO8601DateFormatter/ISO8601DateFormatter.m',
line: 176
)
end
Expand Down

0 comments on commit 340e017

Please sign in to comment.