Added IsOrderFilter #707
Merged
Added IsOrderFilter #707
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I took a look at this and offered @zljlzljlz some pointers. She made a lot of progress, which should hopefully be pushed soon. |
|
Thanks both, I look forward to seeing this when pushed 👍 |
|
It looks like Otherwise, this is looking good – I'd recommend merging after that change. |
|
Agreed I'll be happy to merge when the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#522 - returns true if the specified subset is upwards closed, false if not, based on IsOrderIdeal.