Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added method AllUndirectedSimpleCircuits #689

Merged
merged 4 commits into from
Aug 30, 2024
Merged

Added method AllUndirectedSimpleCircuits #689

merged 4 commits into from
Aug 30, 2024

Conversation

MeikeWeiss
Copy link
Contributor

I added a method that computes all undirected simple circuits by using the method AllSimpleCircuits.

@james-d-mitchell james-d-mitchell added the new-feature A label for new features. label Aug 30, 2024
reiniscirpons
reiniscirpons requested changes Aug 30, 2024
View reviewed changes
Copy link
Collaborator

@reiniscirpons reiniscirpons left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. Some small efficiency improvements and its good to go.

gap/attr.gi Outdated Show resolved Hide resolved
gap/attr.gi Outdated Show resolved Hide resolved
@reiniscirpons
Copy link
Collaborator

reiniscirpons commented Aug 30, 2024 •
edited
Loading

Ill wait for the CI to pass then merge, thanks again!

@james-d-mitchell james-d-mitchell merged commit d56638c into digraphs:main Aug 30, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reiniscirpons reiniscirpons reiniscirpons approved these changes

Assignees
No one assigned
Labels
new-feature A label for new features.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MeikeWeiss @reiniscirpons @james-d-mitchell