feat: api 404 handling #870
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Updated apiService to remove blanket 404 redirection logic - Adjusted announcements page to handle empty states - Added Playwright tests for empty array scenario RISDEV-4872
RISDEV-4872
RISDEV-4872
hamo225
changed the title
- Added a watcher to redirect to the 404 page if the `useGetNorm` API call returns a 404 status. - Updated error handling to display `RisErrorCallout` for non-404 errors. RISDEV-4872
- Added a watcher to redirect to the 404 page if the `useGetNormHtml` API call returns a 404 status. - Updated error handling logic to conditionally display `RisErrorCallout` for non-404 errors or `loadXmlError`. RISDEV-4872
- Added test for redirecting to the 404 page when `useGetNorm` returns a 404 response. - Added test for redirecting to the 404 page when `useGetNormHtml` returns a 404 response. RISDEV-4872
- enriched the error object with the status codes - Removed blanket 404 handling - Adjusted test assertions to include the `status` property in the error object. RISDEV-4872
RISDEV-4872
- Adds watch logic to redirect to NotFound page when the Articles API returns a 404, as this renders the page non-functional. - error callout is used for non-404 errors to provide feedback without breaking navigation. - Added E2E tests for redirection to the NotFound page on 404 and for displaying of an error callout for non-404 errors. RISDEV-4872
- Implemented logic to redirect to the "NotFound" page when `useNormXml` fails with a 404 error. - Added an E2E test to verify 404 behavior RISDEV-4872
RISDEV-4872
This reverts commit ff5f1a6.
|
|
andreasphil
approved these changes
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RISDEV-4872