Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicitly use ubuntu-24.04 to try and see the consequences #42

Merged
merged 1 commit into from
Jan 9, 2025
Merged

Explicitly use ubuntu-24.04 to try and see the consequences #42

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/frontend-build-image-and-scan.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ on:

jobs:
frontend-build-image-and-scan:
runs-on: ubuntu-latest
runs-on: ubuntu-24.04
steps:
- uses: actions/checkout@v4
- name: Build frontend image
Expand Down Expand Up @@ -107,4 +107,4 @@ jobs:
uses: digitalservicebund/notify-on-failure-gha@814d0c4b2ad6a3443e89c991f8657b10126510bf # v1.5.0
if: ${{ failure() && github.ref == 'refs/heads/main' }}
with:
SLACK_WEBHOOK_URL: ${{ secrets.SLACK_WEBHOOK_URL }}
SLACK_WEBHOOK_URL: ${{ secrets.SLACK_WEBHOOK_URL }}
12 changes: 6 additions & 6 deletions .github/workflows/frontend-checks.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ on:

jobs:
lint-and-format-check-frontend:
runs-on: ubuntu-latest
runs-on: ubuntu-24.04
steps:
- uses: actions/checkout@v4
- name: Setup Node
Expand Down Expand Up @@ -39,7 +39,7 @@ jobs:
SLACK_WEBHOOK_URL: ${{ secrets.SLACK_WEBHOOK_URL }}

build-frontend:
runs-on: ubuntu-latest
runs-on: ubuntu-24.04
steps:
- uses: actions/checkout@v4
- name: Setup Node
Expand Down Expand Up @@ -72,7 +72,7 @@ jobs:
SLACK_WEBHOOK_URL: ${{ secrets.SLACK_WEBHOOK_URL }}

unit-test-frontend:
runs-on: ubuntu-latest
runs-on: ubuntu-24.04
steps:
- uses: actions/checkout@v4
- name: Setup Node
Expand Down Expand Up @@ -113,7 +113,7 @@ jobs:
SLACK_WEBHOOK_URL: ${{ secrets.SLACK_WEBHOOK_URL }}

e2e-test-frontend:
runs-on: ubuntu-latest
runs-on: ubuntu-24.04
container:
image: mcr.microsoft.com/playwright:v1.49.1-noble
options: --user 1001
Expand Down Expand Up @@ -157,7 +157,7 @@ jobs:
SLACK_WEBHOOK_URL: ${{ secrets.SLACK_WEBHOOK_URL }}

code-quality-check-with-sonarqube:
runs-on: ubuntu-latest
runs-on: ubuntu-24.04
steps:
- uses: actions/checkout@v4
with:
Expand Down Expand Up @@ -196,7 +196,7 @@ jobs:
SLACK_WEBHOOK_URL: ${{ secrets.SLACK_WEBHOOK_URL }}

license-audit-frontend:
runs-on: ubuntu-latest
runs-on: ubuntu-24.04
steps:
- uses: actions/checkout@v4
- name: Setup Node
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/frontend-deploy-staging.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ on:

jobs:
deploy-staging:
runs-on: ubuntu-latest
runs-on: ubuntu-24.04
concurrency:
group: deploy-staging
cancel-in-progress: true
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/frontend-push-image-to-registry.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ on:

jobs:
frontend-push-image-to-registry:
runs-on: ubuntu-latest
runs-on: ubuntu-24.04
steps:
- uses: actions/cache@v4
with:
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/security-jobs.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ on:

jobs:
security-scan-with-trivy: # open source security scanner, cf. https://trivy.dev/
runs-on: ubuntu-latest
runs-on: ubuntu-24.04
steps:
- name: Checkout code
uses: actions/checkout@v4
Expand Down Expand Up @@ -39,7 +39,7 @@ jobs:
# cf https://digitalservicebund.atlassian.net/browse/RISDEV-5193

secrets-scan-with-talisman: # scan for secrets that were published by mistake (we have a pre-commit and pre-push hook, but who knows)
runs-on: ubuntu-latest
runs-on: ubuntu-24.04
# Running on main only https://digitalservicebund.slack.com/archives/C046VD44ZEH/p1706516240974409
# if: ${{ github.ref == 'refs/heads/main' }}
steps:
Expand Down
Loading