Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't filter out issues with 'info' severity #590

Merged
merged 3 commits into from
Oct 31, 2024

Conversation

rosado
Copy link
Collaborator

@rosado rosado commented Oct 25, 2024

What type of PR is this? (check all applicable)

  • Bug Fix

Description

See #588 for details. This pr updates the query to not filter out the NULL or 'info' severity issues.

Related Tickets & Documents

See #588

QA Instructions, Screenshots, Recordings

The data that triggered the issue has changed since then, so comparing the behaviour seen via preview link to behaviour in production will not let you easily verify it works.

Added/updated tests?

We encourage you to keep the code coverage percentage at 80% and above.

  • No, and this is why: this relies on data returned by external system, we would need a test db (with identical schema).

Summary by CodeRabbit

  • New Features

    • Introduced new functions for enhanced message handling from CSV files.
    • Improved SQL queries to filter issues based on severity, focusing on 'error' records.
  • Bug Fixes

    • Enhanced error handling with clearer logging for unknown issue types and missing fields.
  • Documentation

    • Minor adjustments made for clarity in comments and documentation.

Copy link

github-actions bot commented Oct 25, 2024

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 62.52% 3615 / 5782
🔵 Statements 62.52% 3615 / 5782
🔵 Functions 63.33% 152 / 240
🔵 Branches 80.83% 426 / 527
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
src/services/performanceDbApi.js 65.61% 92.3% 29.41% 65.61% 49-77, 114-116, 177-181, 202-204, 253-259, 270-273, 284-297, 306-322, 336-350, 364-381, 392-419, 423-427, 438-441
Generated in workflow #135 for commit 6a6463a by the Vitest Coverage Report Action

@rosado rosado added the bug Something isn't working label Oct 25, 2024
@digital-land digital-land deleted a comment from coderabbitai bot Oct 30, 2024
@rosado rosado marked this pull request as ready for review October 30, 2024 13:07
Copy link
Contributor

coderabbitai bot commented Oct 30, 2024

Walkthrough

The changes in the src/services/performanceDbApi.js file enhance message handling and SQL query construction. New logic for processing CSV files with issue messages is introduced, storing data in a Map. Functions such as getEntityMessages and getAllRowsMessages are added to handle additional message types. The lpaOverviewQuery function's SQL query is modified to filter records based on severity. Enhanced logging is added to the getTaskMessage function for better error handling. Minor adjustments to comments and documentation clarify function purposes.

Changes

File Change Summary
src/services/performanceDbApi.js - Enhanced message handling and SQL query construction.
- Added logic for processing CSV files.
- Added functions getEntityMessages and getAllRowsMessages for additional message types.
- Modified lpaOverviewQuery to filter records by severity.
- Improved logging in getTaskMessage for unknown issue types.
- Minor adjustments to comments and documentation.

Poem

In the burrow deep, where data flows,
A rabbit hops where the SQL grows.
With messages clear and errors few,
We dance with CSVs, oh what a view!
So let us cheer for the code refined,
In the world of performance, joy we find! 🐇✨


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 885bbaf and 6a6463a.

📒 Files selected for processing (1)
  • src/services/performanceDbApi.js (0 hunks)
💤 Files with no reviewable changes (1)
  • src/services/performanceDbApi.js

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@rosado rosado changed the title fix: don't filter out issues with null severity or info fix: don't filter out issues with 'info' severity Oct 31, 2024
@eveleighoj eveleighoj temporarily deployed to submit-pr-590 October 31, 2024 11:12 Inactive
@rosado rosado merged commit fb34a92 into main Oct 31, 2024
5 checks passed
@rosado rosado deleted the rosado/588-include-ds-info-severity branch October 31, 2024 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants