Create landing page #468
Merged
Create landing page #468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CharliePatterson
previously approved these changes
Sep 24, 2024
alextea
force-pushed
the
landing-page
branch
from
90d05cb to
e70c491
Compare
DilwoarH
temporarily deployed
to
development
GitHub Actions
Inactive
|
Should the beta banner section have a blue background? |
I don't think so, GOV.UK One Login doesn't: https://www.sign-in.service.gov.uk/ |
|
Preview link: https://submit-pr-468.herokuapp.com/ |
rosado
approved these changes
Sep 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
Create a landing page to explain the service for LPAs
Preview link
Preview link: https://submit-pr-468.herokuapp.com/
Related Tickets & Documents
QA Instructions, Screenshots, Recordings
Currently has it's own route at
/landingbut should replace the start page once reviewed by @CharliePattersonAdded/updated tests?
We encourage you to keep the code coverage percentage at 80% and above.
have not been included
[optional] Are there any post deployment tasks we need to perform?
[optional] Are there any dependencies on other PRs or Work?