Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update docker file to be multistage #43

Merged
merged 1 commit into from
Jan 9, 2024
Merged

Conversation

GeorgeGoodall
Copy link
Contributor

@GeorgeGoodall GeorgeGoodall commented Jan 8, 2024

Ticket: https://trello.com/c/Qa0WRVxc/1115-improve-the-dockerfile-for-the-lpa-data-validator-to-be-a-multistage-build

this PR changes the docker image to be built using a multi stage build

it reduces the docker image size from 257mb to 82mb

Copy link
Contributor

@ssadhu-sl ssadhu-sl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@GeorgeGoodall GeorgeGoodall merged commit 7c776d1 into main Jan 9, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants