Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update submit name and move block above data design #298

Merged
merged 1 commit into from
Oct 2, 2024

Conversation

alextea
Copy link
Contributor

@alextea alextea commented Sep 12, 2024

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update

Description

  • fixes broken URL and change title to reflect new naming

  • move submit block above data design block to reflect priority — as discussed with @gwencariad and @colmjude

Related Tickets & Documents

QA Instructions, Screenshots, Recordings

Added/updated tests?

We encourage you to keep the code coverage percentage at 80% and above.

  • Yes
  • No, and this is why: please replace this line with details on why tests
    have not been included
  • I need help with writing tests

[optional] Are there any post deployment tasks we need to perform?

[optional] Are there any dependencies on other PRs or Work?

- fixes broken URL and change title to reflect new naming

- move submit block above data design block to reflect priority — as discussed with @gwencariad and @colmjude
Copy link
Member

@stevenjmesser stevenjmesser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This shouldn’t need tests as there weren’t any for the original PR. Thanks for spotting it and raising it, @alextea.

@alextea alextea merged commit 066d2d9 into main Oct 2, 2024
4 checks passed
@alextea alextea deleted the homepage-updates branch October 2, 2024 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants