Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for Trello #3443: Corrected Docker Compose setup for Security Scanning #297

Merged
merged 2 commits into from
Sep 20, 2024

Conversation

cpcundill
Copy link
Contributor

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update

Description

Corrected Docker Compose setup for Security Scanning by tweaking environment variables and volume mounts.

Also added call to make frontend to the Security Scanning GHA workflow to ensure static resources are generated prior to running the docker compose setup.

Related Tickets & Documents

QA Instructions, Screenshots, Recordings

Added/updated tests?

  • Yes
  • No, and this is why: a successful run of the security scanning GHA workflow will prove whether this fix is valid
  • I need help with writing tests

@cpcundill cpcundill requested a review from eveleighoj September 6, 2024 15:29
Copy link
Contributor

@ssadhu-sl ssadhu-sl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ssadhu-sl ssadhu-sl merged commit 060944e into main Sep 20, 2024
4 checks passed
@ssadhu-sl ssadhu-sl deleted the fix/trello-3443-docker-compose-security-setup branch September 20, 2024 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants