Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Use current version of app in security scanning #295

Merged
merged 1 commit into from
Sep 2, 2024

Conversation

cpcundill
Copy link
Contributor

@cpcundill cpcundill commented Sep 2, 2024

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update

Description

Change version of app to latest when performing security scanning

Docker compose configuration for security scanning was referencing a version of the frontend from around 2 years ago.

Related Tickets & Documents

QA Instructions, Screenshots, Recordings

Run the security scan GitHub workflow.

Added/updated tests?

We encourage you to keep the code coverage percentage at 80% and above.

  • Yes
  • No, and this is why: Existing tests cover the change and an absence of the polyfill issue will prove this fix is effective.
  • I need help with writing tests

@cpcundill cpcundill requested a review from eveleighoj September 2, 2024 09:13
@cpcundill cpcundill merged commit 6a21d6e into main Sep 2, 2024
4 checks passed
@cpcundill cpcundill deleted the fix/trello-3443-app-version branch September 2, 2024 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants