Skip to content

Commit

Permalink
removes unnecessary pipeline_dir fixtures
Browse files Browse the repository at this point in the history
  • Loading branch information
CarlosCoelhoSL committed Dec 2, 2024
1 parent 7f093bf commit 1727cc8
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 20 deletions.
9 changes: 0 additions & 9 deletions tests/acceptance/test_add_data.py
Original file line number Diff line number Diff line change
Expand Up @@ -16,12 +16,6 @@ def specification_dir(tmp_path_factory):
return specification_dir


@pytest.fixture(scope="function")
def pipeline_dir(tmp_path_factory):
pipeline_dir = tmp_path_factory.mktemp("pipeline")
return pipeline_dir


@pytest.fixture(scope="function")
def collection_dir(tmp_path_factory):
collection_dir = tmp_path_factory.mktemp("collection")
Expand Down Expand Up @@ -136,7 +130,6 @@ def create_input_csv(
def test_cli_add_data(
collection_dir,
specification_dir,
pipeline_dir,
organisation_csv,
mock_request_get,
monkeypatch,
Expand Down Expand Up @@ -177,7 +170,6 @@ def test_cli_add_data(
def test_cli_add_data_incorrect_input_data(
collection_dir,
specification_dir,
pipeline_dir,
organisation_csv,
mock_request_get,
):
Expand Down Expand Up @@ -216,7 +208,6 @@ def test_cli_add_data_incorrect_input_data(
def test_cli_add_data_consecutive_runs(
collection_dir,
specification_dir,
pipeline_dir,
organisation_csv,
mock_request_get,
monkeypatch,
Expand Down
13 changes: 2 additions & 11 deletions tests/integration/test_add_data.py
Original file line number Diff line number Diff line change
Expand Up @@ -16,12 +16,6 @@ def specification_dir(tmp_path_factory):
return specification_dir


@pytest.fixture(scope="function")
def pipeline_dir(tmp_path_factory):
pipeline_dir = tmp_path_factory.mktemp("pipeline")
return pipeline_dir


@pytest.fixture(scope="function")
def collection_dir(tmp_path_factory):
collection_dir = tmp_path_factory.mktemp("collection")
Expand Down Expand Up @@ -136,7 +130,6 @@ def create_input_csv(
def test_validate_and_add_data_input_no_error(
collection_dir,
specification_dir,
pipeline_dir,
organisation_csv,
caplog,
mock_request_get,
Expand Down Expand Up @@ -166,7 +159,7 @@ def test_validate_and_add_data_input_no_error(


def test_validate_and_add_data_input_missing_columns(
collection_dir, specification_dir, pipeline_dir, organisation_csv, mock_request_get
collection_dir, specification_dir, organisation_csv, mock_request_get
):
collection_name = "conservation-area"
missing_column_input_data = {
Expand Down Expand Up @@ -340,7 +333,6 @@ def test_validate_and_add_data_input_missing_columns(
def test_validate_and_add_data(
collection_dir,
specification_dir,
pipeline_dir,
organisation_csv,
mock_request_get,
input_data,
Expand All @@ -360,7 +352,7 @@ def test_validate_and_add_data(


def test_validate_and_add_data_input_non_200(
collection_dir, specification_dir, pipeline_dir, organisation_csv, capsys, mocker
collection_dir, specification_dir, organisation_csv, capsys, mocker
):

mock_response = Mock()
Expand Down Expand Up @@ -399,7 +391,6 @@ def test_validate_and_add_data_input_non_200(
def test_validate_and_add_data_input_duplicate_endpoint(
collection_dir,
specification_dir,
pipeline_dir,
organisation_csv,
capsys,
mock_request_get,
Expand Down

0 comments on commit 1727cc8

Please sign in to comment.