fix(tab-bar): fix tab-bar's bug in async scene

didi · Aug 31, 2018 · 88a0774 · 88a0774
1 parent f5c9359
commit 88a0774
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/src/components/tab-bar/tab-bar.vue b/src/components/tab-bar/tab-bar.vue
@@ -95,7 +95,7 @@
           offset = `${offset}px`
         }
         if (slider) {
-          if (this.useTransition) slider.style[TRANSITION] = `all 0.2s linear`
+          if (this.useTransition) slider.style[TRANSITION] = `${TRANSFORM} 0.2s linear`
           slider.style[TRANSFORM] = `translateX(${offset}) translateZ(0)`
         }
       },

diff --git a/src/components/tab-panels/tab-panels.vue b/src/components/tab-panels/tab-panels.vue
@@ -20,6 +20,7 @@
   const TRANSFORM = prefixStyle('transform')
 
   const COMPONENT_NAME = 'cube-tab-panels'
+  const INDEX_OUT_OF_BOUNDARY = -1
 
   export default {
     name: COMPONENT_NAME,
@@ -43,6 +44,10 @@
     methods: {
       _move(label) {
         const curIndex = findIndex(this.panels, panel => panel.label === label)
+        /* istanbul ignore if */
+        if (curIndex === INDEX_OUT_OF_BOUNDARY) {
+          return
+        }
         const panelsGroup = this.$refs.panelsGroup
         const distance = -(curIndex * 100)
         panelsGroup.style[TRANSFORM] = `translateX(${distance}%)`