Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Schwab converter #76

Merged
merged 12 commits into from
May 31, 2024
Merged

Fix Schwab converter #76

merged 12 commits into from
May 31, 2024

Conversation

dickwolff
Copy link
Owner

@dickwolff dickwolff commented May 21, 2024

Added

  • πŸ—οΈ Added version to logging, to help future issue analysis
  • πŸ•΅πŸΌβ€β™‚οΈ Added test coverage to the SecurityService.

Fixes

  • πŸ› Bumped some dependencies
  • πŸ› Made SecurityService more robust, so it should not throw Yahoo Finance errors when symbol is empty
  • πŸ› Schwab: Added transfer to list of ignored records
  • πŸ› Schwab: Added non-qualified div as cash position

Checklist

  • Added relevant changes to README (if applicable)
  • Added relevant test(s)
  • Updated GitVersion file

Related issue (if applicable)

Fixes #75
Fixes #61

Repository owner deleted a comment from github-actions bot May 21, 2024
Repository owner deleted a comment from github-actions bot May 28, 2024
Repository owner deleted a comment from github-actions bot May 28, 2024
Repository owner deleted a comment from github-actions bot May 28, 2024
Repository owner deleted a comment from github-actions bot May 28, 2024
Copy link

Code Coverage

Package Line Rate Branch Rate Complexity Health
src 100% 99% 0 βœ”
src.converters 98% 90% 0 βœ”
src.helpers 100% 100% 0 βœ”
Summary 98% (830 / 847) 91% (396 / 434) 0 βœ”

Repository owner deleted a comment from github-actions bot May 28, 2024
@dickwolff dickwolff merged commit 2e0ac3b into main May 31, 2024
4 checks passed
@dickwolff dickwolff deleted the fix/Schwab-Headers branch May 31, 2024 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Swchab conversion error Add test coverage to SecurityService.ts
1 participant