Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEGIRO: Match transactions with their fees through the orderId #43

Conversation

Sonlis
Copy link
Contributor

@Sonlis Sonlis commented Mar 20, 2024

Added

  • A check that record and record n+1 share the same order ID.

Fixes

@Sonlis Sonlis requested a review from dickwolff as a code owner March 20, 2024 14:50
@Sonlis Sonlis changed the title Match the transaction with its fees through the orderId Match transactions with their fees through the orderId Mar 20, 2024
@dickwolff dickwolff changed the title Match transactions with their fees through the orderId DEGIRO: Match transactions with their fees through the orderId Apr 3, 2024
@dickwolff dickwolff merged commit de44032 into dickwolff:main Apr 3, 2024
0 of 2 checks passed
@dickwolff
Copy link
Owner

I saw the test failed, but aparently another change I made earlier caused a transaction to not be counted to the total. Will merge this now and look into that test later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants