Make DEGIRO V2 GA

dickwolff · May 5, 2024 · e29e8fa · e29e8fa
1 parent f841e6c
commit e29e8fa
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 21 deletions.
diff --git a/GitVersion.yml b/GitVersion.yml
@@ -1,4 +1,4 @@
-next-version: 0.12.1
+next-version: 0.12.2
 assembly-informational-format: "{NuGetVersion}"
 mode: ContinuousDeployment
 branches:

diff --git a/README.md b/README.md
@@ -118,7 +118,6 @@ The following parameters can be given to the Docker run command.
 | `--env GHOSTFOLIO_ACCOUNT_ID=xxxxxxx` | N | Your Ghostolio account ID [^1] |
 | `--env USE_POLLING=true` | Y | When set to true, the container will continously look for new files to process and the container will not stop. |
 | `--env DEBUG_LOGGING=true` | Y | When set to true, the container will show logs in more detail, useful for error tracing. |
-| `--env FORCE_DEGIRO_V2=true` | Y | When set to true, the converter will use the DEGIRO V2 converter (currently in beta) when a DEGIRO file was found. |
 | `--env PURGE_CACHE=true` | Y | When set to true, the file cache will be purged on start. |
 | `--env GHOSTFOLIO_VALIDATE=true` | Y | When set to true, the tool with automatically validate the generated file against Ghostfolio. |
 | `--env GHOSTFOLIO_IMPORT=true` | Y | When set to true, the tool will try to automatically import the generated file into Ghostfolio. |

diff --git a/src/converter.ts b/src/converter.ts
@@ -62,18 +62,13 @@ async function createConverter(converterType: string): Promise<AbstractConverter
 
     switch (converterType) {
 
-        case "degiro":
-            console.log("[i] Processing file using DeGiro converter");
-            console.log("[i] NOTE: There is a new version available of the DeGiro converter");
-            console.log("[i] The new converter has multiple record parsing improvements and also supports platform fees.");
-            console.log("[i] The new converter is currently in beta and we're looking for your feedback!");
-            console.log("[i] You can run the beta converter with the command 'npm run start degiro-v2'.");
+        case "degiro-v1":
+            console.log("[i] Processing file using DeGiro converter (V1)");
+            console.log("[i] NOTE: This version of the DeGiro converter is deprecated and will no longer receive updates.");
             converter = new DeGiroConverter(securityService);
             break;
-        case "degiro-v2":
-            console.log("[i] Processing file using DeGiro converter (V2 Beta)");
-            console.log("[i] NOTE: You are running a converter that is currently in beta.");
-            console.log("[i] If you have any issues, please report them on GitHub. Many thanks!");
+        case "degiro":
+            console.log("[i] Processing file using DeGiro converter");
             converter = new DeGiroConverterV2(securityService);
             break;
         case "etoro":

diff --git a/src/watcher.ts b/src/watcher.ts
@@ -44,15 +44,7 @@ chokidar
         }
 
         let converter = headers.get(converterKey);
-
-        // Temporary control to force DEGIRO V2 converter while in beta.
-        if (process.env.FORCE_DEGIRO_V2 && converter === "degiro") {
-            converter = "degiro-v2"
-            console.log(`[i] Determined the file type to be of kind '${converter}' (overidden by environment variable).`);
-        }
-        else {
-            console.log(`[i] Determined the file type to be of kind '${converter}'.`);
-        }
+        console.log(`[i] Determined the file type to be of kind '${converter}'.`);
 
         // Determine convertor type and run conversion.
         createAndRunConverter(converter, filePath, outputFolder,