Merge pull request #42 from dickwolff/feature/Fix-DegiroV2-French

Fix transaction fees in French exports
dickwolff · Apr 3, 2024 · 7211fec · 7211fec
2 parents e4d0ee3 + 3b45275
commit 7211fec
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 4 deletions.
diff --git a/GitVersion.yml b/GitVersion.yml
@@ -1,4 +1,4 @@
-next-version: 0.7.1
+next-version: 0.7.2
 assembly-informational-format: "{NuGetVersion}"
 mode: ContinuousDeployment
 branches:

diff --git a/sample-degiro-export.csv b/sample-degiro-export.csv
@@ -44,4 +44,6 @@ Datum,Tijd,Valutadatum,Product,ISIN,Omschrijving,FX,Mutatie,,Saldo,,Order Id
 05-02-2024,07:16,31-01-2024,,,DEGIRO Aansluitingskosten 2024 (Nasdaq - NDQ),,EUR,-2.50,EUR,-6.28,
 05-02-2024,07:16,31-01-2024,,,DEGIRO Aansluitingskosten 2024 (Euronext Milan - MIL),,EUR,-2.50,EUR,-3.78,
 05-02-2024,07:16,31-01-2024,,,DEGIRO Aansluitingskosten 2024 (Xetra - XET),,EUR,-2.50,EUR,-1.28,
-02-02-2024,08:00,01-02-2024,AT&T INC.,US00206R1023,Dividend,,USD,1.39,USD,1.39,
+02-02-2024,08:00,01-02-2024,AT&T INC.,US00206R1023,Dividend,,USD,1.39,USD,1.39,
+11-03-2024,10:39,11-03-2024,QT GROUP OYJ,FI4000198031,Frais DEGIRO de courtage et/ou de parties tierces,,EUR,-4.90,EUR,33.53,cce1bd4c-9404-49b0-b69a-43a5c307d3c5
+11-03-2024,10:39,11-03-2024,QT GROUP OYJ,FI4000198031,"Achat 6 QT GROUP OYJ@79,96 EUR (FI4000198031)",,EUR,-479.76,EUR,38.43,cce1bd4c-9404-49b0-b69a-43a5c307d3c5
diff --git a/src/converters/degiroConverterV2.test.ts b/src/converters/degiroConverterV2.test.ts
@@ -33,7 +33,7 @@ describe("degiroConverterV2", () => {
       // Assert
       expect(actualExport).toBeTruthy();
       expect(actualExport.activities.length).toBeGreaterThan(0);
-      expect(actualExport.activities.length).toBe(15);
+      expect(actualExport.activities.length).toBe(16);
 
       done();
     }, () => { done.fail("Should not have an error!"); });

diff --git a/src/converters/degiroConverterV2.ts b/src/converters/degiroConverterV2.ts
@@ -199,7 +199,6 @@ export class DeGiroConverterV2 extends AbstractConverter {
       "debitering",
       "rente",
       "interesse",
-      "ag",
       "verrekening promotie",
       "operation de change",
       "versement de fonds",