Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UDA improvements #412

Merged
merged 11 commits into from
Nov 10, 2023
Merged

UDA improvements #412

merged 11 commits into from
Nov 10, 2023

Conversation

crisdut
Copy link
Member

@crisdut crisdut commented Nov 7, 2023 •
edited
Loading

Description

This PR intent solve the issue #404

Changes

  • Now we have a new method to extract and upload all media information in rgb-proxy (previously, this was done within the issuance method). Parameters:
    • preview: Represents the preview/thumbnail of the media. The BMC gets the base64 of the media to embedded in the RGB21 contract.
    • media: Represents the sha2 of the media. The BMC download binary and get the sha2 of the media (Compatible to Iris Wallet).
    • attachments: Intended for other media information, such as the high-definition hash (in blake3).
  • Now the issuing method will only receive media type and digest (aka. hash).

TODO

  • Split extract metadata and issue contract
  • Issue contract operation receive only media type and digest (hash)
  • Upload media after extract metadata (rgb-proxy)
  • RGB21 is mint with preview, media and attachments information (the last information is optional).
  • Expose method in web.rs
  • Change typescript structs

Closes #404

@crisdut crisdut marked this pull request as draft November 7, 2023 23:22
@cryptoquick
Copy link
Member

Interesting... You don't think this requires any changes to typescript types? Do we need to do anything different on the client?

@crisdut
Copy link
Member Author

crisdut commented Nov 7, 2023

Interesting... You don't think this requires any changes to typescript types? Do we need to do anything different on the client?

This PR is incomplete. Please, see TODO section.

@cryptoquick cryptoquick changed the title UDA improviments UDA improvements Nov 8, 2023
@crisdut crisdut changed the base branch from development to CD/375 November 10, 2023 06:00
@crisdut crisdut marked this pull request as ready for review November 10, 2023 06:00
Base automatically changed from CD/375 to development November 10, 2023 08:29
@Gigi3d
Copy link
Contributor

Gigi3d commented Nov 10, 2023

loving this

josediegorobles
josediegorobles approved these changes Nov 10, 2023
View reviewed changes
Copy link
Member

@josediegorobles josediegorobles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cryptoquick cryptoquick added this pull request to the merge queue Nov 10, 2023
Merged via the queue into development with commit 7219909 Nov 10, 2023
5 checks passed
@cryptoquick cryptoquick deleted the CD/404 branch November 10, 2023 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josediegorobles josediegorobles josediegorobles approved these changes

@cryptoquick cryptoquick Awaiting requested review from cryptoquick

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

UDA Attachment Improvements
4 participants
@crisdut @cryptoquick @Gigi3d @josediegorobles