Use modern glutin+winit API #4
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
swash_demo crashes on Wayland on my machine.
I wondered why #2 was happening and tried myself on Wayland (it seemed to be a logic bug, specifically an option being
unwrapped, but maybe it happened because of something else), only to get a completely different error. Upon searching what that error was, the bunch of links I saw pointed to the fact that the issue was fixed in later versions of glutin.So I tried porting swash_demo to the new glutin API which is now completely separate from winit.
Now it works on Wayland and X11, and should work on Windows and MacOS without any problems.