Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#3: implementation component rules C5 - C7 - violations #42

Draft
wants to merge 5 commits into
base: violations/component
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
package com.devonfw.sample.archunit.componentA.dataaccess;

import com.devonfw.sample.archunit.task.dataaccess.TaskItemEntity;

public class C6ViolationDataaccessLayerOfComponentADependsOnDataaccessLayerOfComponentTask {
TaskItemEntity taskItemEntity;
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
package com.devonfw.sample.archunit.componentA.logic;

import com.devonfw.sample.archunit.task.dataaccess.TaskItemEntity;

public class C5ViolationLogicLayerOfComponentADependsOnDataaccessLayerOfComponentTask {
TaskItemEntity taskItemEntity;
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
package com.devonfw.sample.batch.task.batchLayer;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/devonfw/devon4j/blob/master/documentation/architecture.asciidoc#technical-architecture

The term Layer is not part of the package definition. It is just logic, dataaccess, batch, etc.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that was a following mistake from my misunderstanding earlier. I will fix that now.


import com.devonfw.sample.archunit.task.logic.UcDeleteTaskItem;

public class C7ViolationBatchLayerOfBatchDependsOnLogicLayerOfComponentTask {
UcDeleteTaskItem ucDeleteTaskItem;
}