#5: implement thirdparty violations #23
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added hibernate and springframework dependencies to exhibit violations. Refactored E1, E3, and E4 to have a more concise debug notification.
Refactored the class with respect to @hohwille review annotations.
Refactored violations to include review annotations
Concerning @hohwille review annotation, I adjusted the E3 Rule to correctly check for layers. I added two public static final patterns for the common and dataaccess layers to use instead of the faulty contains() check which would trigger false positive errors.
Refactored via automatic devonfw-ide code formatting. Adjusted ArchCondition to fit the recent rule.
ThirdPartyRulesTest.java: - combined all third-party rules inside ThirdPartyRulesTest.java - deleted distinct rule test files - changed all ArchRules to public as a part of the preparation for task devonfw-sample#19 - rules 1, 3, and 4 utilize now the present PackageStructure type. --- rules 1 and 4 also test scope-related conditions for classic architecture projects now.
- deleted the deprecated distinct rule test files. - Merged the new scope-related rule tests. - added scope related violations
-Implemented the most recent annotation of @hohwille. -Minor refactoring.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#5
#8
DO NOT MERGE.
This fork branch contains classes demonstrating archunit thirdparty rules violations:
Namely E1, E3 and E4 violations.