#1: Added Layer rules L1-L12 #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LayerDependencyRulesTest.java includes all necessary tests.
hohwille
requested changes
Jan 30, 2023
Comment on lines
19
to
23
| .layer("common").definedBy("com.devonfw.sample.archunit.common..") // | ||
| .layer("logic").definedBy("com.devonfw.sample.archunit.logic..") // | ||
| .layer("dataaccess").definedBy("com.devonfw.sample.archunit.dataaccess..") // | ||
| .layer("service").definedBy("com.devonfw.sample.archunit.service..") // | ||
| .layer("client").definedBy("com.devonfw.sample.archunit.client..") |
There was a problem hiding this comment.
@vlad961 the package root and especially the component should not be encoded here:
- We might have multiple components in the same application and each could have any up to all out of this layers
- As we want to provide a "starting point" and "template" for projects using devonfw and arch-unit we should not tie this to
com.devonfw.sample.archunitas otherwise every project would have to adopt this to their own root package what is however not neccessary.
There was a problem hiding this comment.
I have changed each layer definition by exchanging the prefix: "com.devonfw.sample.archunit" with a second "." (dot).
src/test/java/com/devonfw/sample/archunit/ArchitectureTest.java
Outdated
Show resolved
Hide resolved
src/test/java/com/devonfw/sample/archunit/LayerDependencyRulesTest.java
Outdated
Show resolved
Hide resolved
src/test/java/com/devonfw/sample/archunit/LayerDependencyRulesTest.java
Outdated
Show resolved
Hide resolved
src/test/java/com/devonfw/sample/archunit/LayerDependencyRulesTest.java
Outdated
Show resolved
Hide resolved
Closed
2 tasks
hohwille
requested changes
Feb 3, 2023
src/test/java/com/devonfw/sample/archunit/ArchitectureTest.java
Outdated
Show resolved
Hide resolved
src/test/java/com/devonfw/sample/archunit/ArchitectureTest.java
Outdated
Show resolved
Hide resolved
Postponed its implementation as discussed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1
Implemented Layer rules L1-12 with Archunit