BuildRequest changes #12
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Throughout Devhub we use
Integersto store the build timeout value, which can also benull. In the build server, we usedintswhich causeNullPointerExceptionsfor some input. These changes allow builds that do not specify a build timeout.Another change in this PR is that the requester doesn't necessarily have to specify the branch name. For example when requesting a commit to be build, finding out to which branch it belongs can be difficult (we would have to add a command for the git server). Since we're already pulling all the branches, we can just checkout a commit to the
headin the working directory when the branch name is unknown.