Implement react-otp-input within docz docmentation #227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@apollonian Please review. Thanks! |
Signed-off-by: Nirmal Khedkar <[email protected]>
|
Please let me know if there are any changes to be done, thank you! |
apollonian
reviewed
Oct 31, 2020
| @@ -200,25 +200,3 @@ Feel free to open [issues](https://github.com/devfolioco/react-otp-input/issues/ | |||
| ## License | |||
|
|
|||
| [](https://github.com/devfolioco/react-otp-input/blob/master/LICENSE) | |||
|
|
|||
| ## Contributors ✨ | |||
There was a problem hiding this comment.
Does docz error out when we have this section in the README?
|
Thanks for working on this @nirmalhk7 and sorry for the delayed response. We updated the file structure with v3 can you reopen the PR with the latest changes? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixed Implement component within docz's playground #210
Any background context you want to provide?
I initially wanted to render the demo in the README.md file. If you copy-paste all content from
demo.mdxintoREADME.md, it works really well on the docz server, but that JSX is also printed directly (with no formatting) in markdown. Therefore we'd have had a great documentation website, but ugly JSX code in the repository's README. That's why I felt it'd be better if the demo is kept separately from the README.If there's a way for JSX to be shown on docz but not on README, please let me know. I've searched online but I couldn't find any way for it.