Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review test matrix; test vs. h5py>=3.8.0 #407

Merged
merged 1 commit into from
Dec 17, 2024

Conversation

crusaderky
Copy link
Collaborator

@crusaderky crusaderky commented Dec 16, 2024

  • Increase max tested Python version from 3.11 to 3.13
  • Test against pinned old versions of all dependencies
  • Set the minimum required versions to the minimum tested versions
  • Clean up compatibility with obsolete dependencies

@crusaderky crusaderky force-pushed the ci_versions branch 2 times, most recently from 0bb2a38 to a932792 Compare December 16, 2024 12:54
@crusaderky crusaderky force-pushed the ci_versions branch 2 times, most recently from 0f5b27f to af0e810 Compare December 16, 2024 13:05
@crusaderky crusaderky marked this pull request as draft December 16, 2024 14:00
@crusaderky crusaderky changed the title Review test matrix Review test matrix; test vs. h5py>=3.3.0 Dec 16, 2024
@crusaderky crusaderky changed the title Review test matrix; test vs. h5py>=3.3.0 Review test matrix; test vs. h5py>=3.8.0 Dec 16, 2024
@crusaderky crusaderky marked this pull request as ready for review December 16, 2024 16:12
@crusaderky crusaderky self-assigned this Dec 16, 2024
Copy link
Collaborator

@peytondmurray peytondmurray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this 🚀

Comment on lines +456 to +459
layout = VirtualLayout(shape, dtype=raw_data.dtype)
layout._src_filenames.add(b".")
space = h5s.create_simple(shape)
selector = Selector(space)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@crusaderky crusaderky merged commit 7c6cd2f into deshaw:master Dec 17, 2024
10 checks passed
@crusaderky crusaderky deleted the ci_versions branch December 17, 2024 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants