-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Review test matrix; test vs. h5py>=3.8.0 #407
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
crusaderky
commented
Dec 16, 2024
•
edited
Loading
edited
- Increase max tested Python version from 3.11 to 3.13
- Test against pinned old versions of all dependencies
- Set the minimum required versions to the minimum tested versions
- Clean up compatibility with obsolete dependencies
crusaderky
commented
Dec 16, 2024
crusaderky
force-pushed
the
ci_versions
branch
2 times, most recently
from
December 16, 2024 12:54
0bb2a38
to
a932792
Compare
crusaderky
commented
Dec 16, 2024
crusaderky
force-pushed
the
ci_versions
branch
2 times, most recently
from
December 16, 2024 13:05
0f5b27f
to
af0e810
Compare
crusaderky
changed the title
Review test matrix
Review test matrix; test vs. h5py>=3.3.0
Dec 16, 2024
crusaderky
changed the title
Review test matrix; test vs. h5py>=3.3.0
Review test matrix; test vs. h5py>=3.8.0
Dec 16, 2024
crusaderky
force-pushed
the
ci_versions
branch
from
December 16, 2024 15:33
206f74b
to
028cc40
Compare
crusaderky
commented
Dec 16, 2024
peytondmurray
approved these changes
Dec 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this 🚀
Comment on lines
+456
to
+459
layout = VirtualLayout(shape, dtype=raw_data.dtype) | ||
layout._src_filenames.add(b".") | ||
space = h5s.create_simple(shape) | ||
selector = Selector(space) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.