[InMemoryDataset redesign] EntireChunksMapper #393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 tasks
crusaderky
force-pushed
the
entire_chunks_mapper
branch
2 times, most recently
from
aab636a to
adb06fc
Compare
crusaderky
force-pushed
the
entire_chunks_mapper
branch
from
adb06fc to
ec3bb2d
Compare
crusaderky
force-pushed
the
entire_chunks_mapper
branch
2 times, most recently
from
36114d5 to
1c7c777
Compare
crusaderky
force-pushed
the
entire_chunks_mapper
branch
from
1c7c777 to
7ad223b
Compare
peytondmurray
approved these changes
Nov 19, 2024
| actual selection may only target part of it. | ||
| """ | ||
|
|
||
| _chunks_indexer: slice | NDArray[np.intp] |
There was a problem hiding this comment.
Does it matter that this is a class attribute rather than an instance attribute? In pure python mode this will share _chunks_indexer across multiple EntireChunksMapper instances, I think? Not sure about how cython handles these...
There was a problem hiding this comment.
This is a normal instance attribute. It's the output of the chunk_indexer method of the original indexer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Blocked by and incorporates:
Add new class EntireChunksMapper, which reamains dormant until a later PR.