Make create_virtual_dataset handle zero-length raw_data correctly #315
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR makes
create_virtual_dataset
correctly handle the case where the raw data is empty, returning an empty virtual dataset.Closes #314.
Changes
(1,)
(??)I'm still not entirely sure why it is necessary to close/open the file descriptor between each operation to reproduce this issue, but it must be something to do with flushing writes to the file. @ArvidJB any ideas?