Optimize _recreate_raw_dataset
to use less memory; add versions method
#300
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR optimizes a part of the
_recreate_raw_dataset
that currently can allocate significant memory for datasets with large numbers of versions. I also saw a large speedup in this section of the code post-refactor.A
VersionedHDF5File.versions
method was added (aVersionedHDF5
should know what versions it has), which should return the same thing asversioned_hdf5.versions.all_versions
but be much less verbose and more convenient.Partially addresses #298. Deleting datasets can still be costly in terms of memory because the operation requires