Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix execute time not showing up after moving a cell #109

Merged
merged 3 commits into from
Jan 29, 2024
Merged

Fix execute time not showing up after moving a cell #109

merged 3 commits into from
Jan 29, 2024

Conversation

krassowski
Copy link
Collaborator

References

Fixes #108

Code changes

  • Add a test ensuring that the extension renders a timing widget when running a cell that has been moved
  • Listen to cell's shared model disposal signal to de-register a cell before the problematic CellList.changed signal emits

User-facing changes

Before After
before after

Backwards-incompatible changes

None

@krassowski krassowski added the bug Something isn't working label Jan 25, 2024
mlucool
mlucool approved these changes Jan 29, 2024
View reviewed changes
Copy link
Member

@mlucool mlucool left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mlucool mlucool merged commit f225908 into deshaw:master Jan 29, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mlucool mlucool mlucool approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Moving cells breaks execute time on that cell
2 participants
@krassowski @mlucool