Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add wait method #3

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

add wait method #3

wants to merge 3 commits into from

Conversation

SadiePi
Copy link

@SadiePi SadiePi commented Jun 28, 2022

Adds a method to EventEmitter called wait that awaits the completion of each listener. Note: awaiting this method does not work the same way as awaiting emit.

@crowlKats crowlKats self-requested a review June 28, 2022 09:37
Copy link
Member

@eliassjogreen eliassjogreen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, @crowlKats any comments?

@crowlKats
Copy link
Member

I dont see much need for this; maybe this should be emit's behaviour? it just seems confusing to have such similar methods

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants